Make installation via homebrew the default instructions for macOS #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
approved these changes
Sep 7, 2017
README.md
Outdated
| @@ -32,6 +32,18 @@ ddev requires ports 80 and 3306 to be available for use on your system when site | |||
| If you need to use another environment after using ddev, simply ensure all of your ddev sites are stopped or removed. ddev only uses system ports when at least one site is running. | |||
|
|
|||
| ## Installation | |||
| ### Homebrew - macOS | |||
|
|
|||
| For macOS users, we recommend downloading and installing ddev via homebrew: | |||
README.md
Outdated
| ``` | ||
| brew tap drud/ddev && brew install ddev | ||
| ``` | ||
| To upgrade to the latest version of ddev, simply run: |
There was a problem hiding this comment.
Probably "Later, to upgrade to a newer version"
README.md
Outdated
| brew upgrade ddev | ||
| ``` | ||
| If you need to install homebrew, instructions can be found [here](https://brew.sh/). | ||
|
|
||
| ### Installation Script - Linux and macOS |
There was a problem hiding this comment.
I'd just change this heading to "Installation Script - MacOS or Linux".
|
@rfay your changes have been made. Does this have the green light to squash and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Homebrew is the most straight forward and is the expected way of installing software for many macOS users.
How this PR Solves The Problem:
This PR solves the problem by listing homebrew as the first installation instruction for macOS. Docs provide code examples to download, install, and upgrade ddev. As well as a link to the homebrew download/install instructions - that user's without homebrew may use as a reference.
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
#434
Release/Deployment notes: