Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated build-tools to 1.0.3 #46

Merged
merged 3 commits into from
Mar 8, 2017

Conversation

rfay
Copy link
Member

@rfay rfay commented Mar 7, 2017

The Problem: Update build tools to 1.0.3

The Fix:

Updates https://github.com/drud/build-tools/releases/tag/1.0.3 - See the enhanced features mentioned there.

The Test:

There shouldn't really be any intrusive changes, but the targets for static analysis have been split out, like make govet, make gofmt. make govendor

IMO this doesn't need extensive review if it passes test and doesn't do you any harm, as the changes were reviewed upstream.

@rfay rfay requested review from tannerjfco and beeradb March 7, 2017 22:28
@rfay
Copy link
Member Author

rfay commented Mar 8, 2017

I did add two tiny commits:

  • Remove the build-tools circle.yml - it certainly isn't useful here.
  • Remove the include of build-tools/makefile_components/base_test_go.mak since we don't use it and it only causes a warning anyway. We're overriding it, and nothing in that include is useful.

@rfay rfay merged commit d411f8f into ddev:master Mar 8, 2017
@rfay rfay deleted the 20170307_update_build_tools_1_0_3 branch March 8, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants