project type filter for ddev list command (ddev list --type=)
#4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
What do you think @cmuench , does this have a future? |
|
@rfay The filter is already working. I had a bigger idea but we can start with this approach. That's why it's currently marked as draft. |
cmuench
force-pushed
the
feature/project-filter
branch
from
0b833df
to
ad85d26
Compare
rfay
requested changes
Apr 6, 2023
There was a problem hiding this comment.
This is looking quite good and is a major code improvement, thanks!
It's missing
- the proper updates to docs to mention the new feature, https://ddev.readthedocs.io/en/latest/users/usage/commands/#list
- It needs to have examples add in the command so
ddev help listwill show this option (and perhaps others).
rfay
changed the title
ddev list command (ddev list --type=)
Done |
mattstein
approved these changes
Apr 7, 2023
Proper naming Co-authored-by: Matt Stein <m@ttste.in>
it's done |
|
Yay, thanks. Back now and will catch up on PRs eventually :) |
No pressure. I was not sure if I had to inform you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
As a user of many different local installed ddev projects I want to filter the
ddev listoutput. Currently we have theonly-activeflag available.Additionally we could filter by project type.
How This PR Solves The Issue
The PR restructures the parameters of the list command into a struct. This prepares the command to get additional filters in the future like tags.
Manual Testing Instructions
Run the
ddev listcommand with new filter option-tor--typeand set a project typeExample:
ddev list -t phporddev list -t magento2.The filter can be combined with active only filter.
ddev list -A -t phpAutomated Testing Overview
I added a simple test which filters by a not existing type. Currently I am looking for a good way to test also the project type filter by an existing type.