Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve formatting, fix typos, remove duplicates #4726

Merged
merged 6 commits into from
Mar 11, 2023
Merged

[docs] Improve formatting, fix typos, remove duplicates #4726

merged 6 commits into from
Mar 11, 2023

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Mar 8, 2023

No description provided.

@rfay
Copy link
Member

rfay commented Mar 8, 2023

He's back, yay!

@stasadev
Copy link
Member Author

stasadev commented Mar 8, 2023

Literally every time I read the docs, I find something useful that I can apply to my configuration and make my workflow easier. Great work!

rfay
rfay requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks so much for careful reading and continuing contributions!

A couple of misunderstandings, etc. Would be happy to have suggestions about how to make these misunderstandings less likely.

docs/content/users/usage/commands.md Outdated Show resolved Hide resolved
docs/content/users/extend/customizing-images.md Outdated Show resolved Hide resolved
docs/content/users/usage/commands.md Outdated Show resolved Hide resolved
@rfay rfay requested a review from mattstein March 8, 2023 18:56
rfay
rfay requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this. The goal with "Prerelease tasks" is to integrate the second set (6 steps) into the first set (bullets). You were right that they shouldn't both be there, but they need to be merged.

@stasadev
Copy link
Member Author

stasadev commented Mar 9, 2023

I understand that it needs to be merged, but I don't know how.

I think I'll leave it to @mattstein, so that "Creating a Release" and "Pushing Docker Images with the GitHub Actions Workflow" don't look nearly the same.

@rfay
Copy link
Member

rfay commented Mar 9, 2023

I can merge those sections.

@rfay rfay marked this pull request as draft March 9, 2023 13:09
@rfay
Copy link
Member

rfay commented Mar 10, 2023

Rebased and merged prerelease tasks into one section.

@rfay rfay marked this pull request as ready for review March 10, 2023 19:35
mattstein
mattstein approved these changes Mar 10, 2023
View reviewed changes
Copy link
Sponsor Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I don’t like about this PR is how much of it I missed in the first place. Thanks @stasadev! Soft unrelated wording suggestion but otherwise it looks good to me.

docs/content/users/topics/sharing.md Outdated Show resolved Hide resolved
docs/content/users/usage/commands.md Show resolved Hide resolved
@stasadev @mattstein
Change the header
7df968f 
Co-authored-by: Matt Stein <m@ttste.in>
@rfay rfay merged commit 88a053f into ddev:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay requested changes

@mattstein mattstein mattstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stasadev @rfay @mattstein