Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document exposing additional non-HTTP ports on web #4736

Merged
merged 4 commits into from
Mar 11, 2023

Conversation

deviantintegral
Copy link
Collaborator

@deviantintegral deviantintegral commented Mar 10, 2023

The Issue

It wasn't clear to me that a services file could only modify the web service, without declaring an additional container to run. When I first started trying to figure this out, I looked on this page so it's where I've added the new docs.

How This PR Solves The Issue

A new section on exposing non-HTTP ports.

@rfay rfay changed the title Document exposing additional non-HTTP ports on web [docs] Document exposing additional non-HTTP ports on web Mar 10, 2023
@deviantintegral deviantintegral marked this pull request as ready for review March 10, 2023 17:55
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@rfay rfay requested a review from mattstein March 10, 2023 17:56
Copy link
Sponsor Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor stylistic nitpicks, otherwise looks good to me!

docs/content/users/extend/customization-extendibility.md Outdated Show resolved Hide resolved
docs/content/users/extend/customization-extendibility.md Outdated Show resolved Hide resolved
deviantintegral and others added 2 commits March 11, 2023 10:22
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Matt Stein <m@ttste.in>
@rfay rfay merged commit 4ea2bde into ddev:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants