Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Magento 2 quickstart for Magento 2.4.6, fixes #4762 #4767

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

cmuench
Copy link
Collaborator

@cmuench cmuench commented Mar 18, 2023

  • Add elasticsearch engine to options
  • Define elasticsearch port
  • Disable depending new Magento_AdminAdobeImsTwoFactorAuth module

See issue: #4762

- Add elasticsearch engine to options
- Define elasticsearch port
- Disable depending new Magento_AdminAdobeImsTwoFactorAuth module
@rfay rfay changed the title Fix Magento 2 quickstart for Magento 2.4.6 [docs] Fix Magento 2 quickstart for Magento 2.4.6, fixes #4762 Mar 18, 2023
@rfay
Copy link
Member

rfay commented Mar 18, 2023

Thanks so much!

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, this works for me. I did see a case where the setup directory didn't get created, and ddev composer install didn't fix that. Thoughts about what might have happened?

@rfay rfay merged commit febfdf0 into ddev:master Mar 29, 2023
@cmuench
Copy link
Collaborator Author

cmuench commented Mar 30, 2023

Thanks so much, this works for me. I did see a case where the setup directory didn't get created, and ddev composer install didn't fix that. Thoughts about what might have happened?

Magento ships a base package with the skeleton of the application. All the files in this packages are copied by a Composer Plugin during "Composer Install".
If something breaks during installation the files are not copied. In that case we have to remove the base package from vendor folder (rm -Rf vendor/magento/magento2-base) and re-run composer install which then triggers the copy of the skel again.
The setup directory is part of the base package.

@rfay
Copy link
Member

rfay commented Mar 30, 2023

So this is a known "issue", and it would have been a result of something (unnoticed) going wrong in ddev composer create, and it doesn't get fixed by ddev composer install

I would have expected to see an error, but maybe that error doesn't stop execution?

Thanks so much for maintaining the Magento stuff. I've been thinking about how we can do automated tests of these quickstarts...

@cmuench
Copy link
Collaborator Author

cmuench commented Mar 30, 2023

@rfay I don't know if most of the people in Magento World are aware of that issue.
At netz98 we developed a "base page redeploy" command for Composer. I already thought to open source that command.
I do not think it's a problem that ddev should fix. We could add a notice to the docs.

@cmuench
Copy link
Collaborator Author

cmuench commented Apr 6, 2023

@rfay I am just working on a composer:redeploy-base-packages command in n98-magerun2 to provide a way to fix this issue.
This will be released with v7.1.0 of n98-magerun2 if tests are successful.
netz98/n98-magerun2#1176

@cmuench cmuench deleted the doc-fix-magento2-quickstart branch April 6, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants