-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Quickstart for ExpressionEngine #4777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and nitpicked!
docs/content/users/quickstart.md
Outdated
|
||
=== "ExpressionEngine Zipfile Download" | ||
|
||
Download the ExpressionEngine code from [ExpressionEngine.com](https://expressionengine.com/), then: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify we’re running things and link back to download+install instructions since they live in a different place for the Git install instructions:
Download the ExpressionEngine code from [ExpressionEngine.com](https://expressionengine.com/), then: | |
Download the ExpressionEngine code from [expressionengine.com](https://expressionengine.com/), then follow the [install instructions](https://docs.expressionengine.com/latest/installation/installation.html) by running the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The odd thing here is that the DDEV instructions are far simpler and easier than the expressionengine.com instructions. You don't have to do most of the things when you use DDEV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figure if it goes sideways it’s nice to have the official reference, but no big deal. Would still lowercase the domain name and “run” the stuff that follows.
|
||
=== "ExpressionEngine Git Checkout" | ||
|
||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide some context:
```bash | |
Follow the instructions in ExpressionEngine’s Git repository [README.md](https://github.com/ExpressionEngine/ExpressionEngine#how-to-install): | |
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the context. Mostly you can't just follow the instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the instructions here are much more straightforward, and it seems to me like they’re following the general steps anyway—the links out aren’t hard requirements (since the steps are immediately detailed below) but only providing context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the links, just with "based on"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That reads better than my suggestion, thank you!
Co-authored-by: Matt Stein <m@ttste.in>
I like the contextual links to their docs, will add a commit to add those with less prescriptive angle on them. |
The Issue
Add a quickstart for ExpressionEngine
How This PR Solves The Issue
Shows zipfile and git checkout approaches.
Manual Testing Instructions
Try it out
Concerns