Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix instructions about restoring snapshots, fixes #4778 #4779

Merged
merged 2 commits into from
May 3, 2023

Conversation

rintisch
Copy link
Contributor

@rintisch rintisch commented Mar 22, 2023

The Issue

#4778

How This PR Solves The Issue

Corrects the incorrect instructions

Manual Testing Instructions

  1. Create a snapshot
  2. Input file name without db type, db version and file extension
  3. See that it works.

Automated Testing Overview

No tests needed, its only about docs.

Related Issue Link(s)

Release/Deployment Notes

Not related to deployment.

Correct the instructions how to restore a given snapshot.

Closes ddev#4778
@rintisch rintisch requested a review from a team as a code owner March 22, 2023 15:07
@rfay rfay changed the title Fix instructions about restoring snapshots [docs] Fix instructions about restoring snapshots, fixes #4778 Mar 22, 2023
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, sorry it got stalled. @mattstein I assume it's OK with you?

Stopping db container for snapshot restore of 'd9_20220107124831-mariadb_10.3.gz'...
Restored database snapshot d9_20220107124831-mariadb_10.3.gz
```

Snapshots are stored as gzipped files in the project’s `.ddev/db_snapshots` directory, and the file created for a snapshot can be renamed as necessary. For example, if you rename the above `d9_20220107124831-mariadb_10.3.gz` file to `working-before-migration-mariadb_10.3.gz`, then you can use `ddev snapshot restore working-before-migration-mariadb_10.3.gz`. (The description of the database type and version`mariadb_10.3`, for examplemust remain intact.)
Snapshots are stored as gzipped files in the project’s `.ddev/db_snapshots` directory, and the file created for a snapshot can be renamed as necessary. For example, if you rename the above `d9_20220107124831-mariadb_10.3.gz` file to `working-before-migration-mariadb_10.3.gz`, then you can use `ddev snapshot restore working-before-migration`. (The description of the database type and version`mariadb_10.3`, for examplemust remain intact.)
Copy link
Sponsor Collaborator

@mattstein mattstein May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you specifically added spaces around the em dash. Apparently Chicago and AP Style are split on this, but in the docs we’ve consistently gone with the spaceless variant aside from this change. Would you mind changing it back or is there a compelling reason we should adopt this style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfay My account got flagged (39 days! And they even didn't tell me why it was flagged...), therefore all my contributions were hidden.

@mattstein Oh, I was not aware that there are rules for this (english is not my mother tongue). I just added them because it looked falsy. But of course can I change it back. I will push an update today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains why I didn't see it! Thanks for letting me know.

Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rintisch!

Remove prior added whitespaces around
em dash to achieve consistent writing style.
stick
@rfay rfay merged commit f7b56f1 into ddev:master May 3, 2023
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants