Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev get should ignore specified yaml files that don't exist, fixes #4774 #4826

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Apr 17, 2023

The Issue

How This PR Solves The Issue

Warn, but don't fail, on missing .platform (or other) yaml files mentioned in install.yaml

Manual Testing Instructions

  • Remove .platform/routes.yaml and then ddev get ddev/ddev-platformsh. ddev start. Make sure things work.

@github-actions
Copy link

@rfay
Copy link
Member Author

rfay commented Apr 17, 2023

@rfay
Copy link
Member Author

rfay commented Apr 17, 2023

This actually works correctly.

I added to the install.yaml in ddev-platformsh (locally)

yaml_read_files:
  platformapp: .platform.app.yaml
  services: .platform/services.yaml
  routes: .platform/routes.yaml
  something: .platform/something.yaml

and ddev get ../ddev-platformsh showed
unable to import yaml file /Users/rfay/workspace/platform-d9mariadb/.platform/something.yaml: unable to read file /Users/rfay/workspace/platform-d9mariadb/.platform/something.yaml (open /Users/rfay/workspace/platform-d9mariadb/.platform/something.yaml: no such file or directory)

And didn't seem to cause any other trouble.

@rfay rfay marked this pull request as ready for review April 17, 2023 18:54
@rfay rfay requested a review from a team as a code owner April 17, 2023 18:54
@rfay rfay changed the title Ignore specified yaml files that don't exist, fixes #4774 ddev get should ignore specified yaml files that don't exist, fixes #4774 Apr 17, 2023
@rfay rfay merged commit 18237c7 into ddev:master Apr 18, 2023
11 checks passed
@rfay rfay deleted the 20230417_get_ignore_nonexistent_yaml branch April 18, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant