Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-sync mutagen volume when necessary, fixes #4797 #4830

Merged
merged 38 commits into from
Apr 23, 2023
Merged

Pre-sync mutagen volume when necessary, fixes #4797 #4830

merged 38 commits into from
Apr 23, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Apr 18, 2023 •
edited

The Issue

A number of things can depend on mutagen sync having already completed. This includes gunicorn and web_extra_daemons

How This PR Solves The Issue

Don't execute actions that may need /var/www/html fully populated until after mutagen has had its chance at it.

TODO

  • Too much output on ddev start, at least when using DDEV_DEBUG=true
  • Container tests failing

Manual Testing Instructions

  • Use casually in both mutagen and non-mutagen situations.
  • Make sure web-entrypoint.d scripts work
  • Manually test using webserver_type: nginx-gunicorn - it should work with or without mutagen.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited

Download the artifacts for this pull request:

See Testing a PR

@rfay rfay mentioned this pull request Apr 18, 2023
Closed
2 tasks
@rfay rfay marked this pull request as ready for review April 18, 2023 22:03
@rfay rfay requested a review from a team as a code owner April 18, 2023 22:03
@rfay rfay force-pushed the 20230417_presync_web_mutagen branch 2 times, most recently from 8792324 to f3f3015 Compare April 22, 2023 15:33
rfay added 24 commits April 22, 2023 12:07
@rfay
Do mutagen sync before other key start.sh, fixes ddev#4797
597eee0
@rfay
Try start.sh again
83fdbb9
@rfay
Seems to be working
da6e1ea
@rfay
Better start and functions handling [skip ci]
71d2586
@rfay
dummy commit to run tests
ab359cc
@rfay
Fix entrypoint was not being recognized [skip ci]
4413c46
@rfay
Empty commit to run tests
ff8d4c2
@rfay
Allow docker-compose exec detach, fix TestDdevLogs
7005976
@rfay
Make sure we have a default DDEV_WEBSERVER_TYPE [skip ci]
1925de9
@rfay
Use /var/tmp/logpipe to get extra stuff into container logs [skip ci]
b4a2847
@rfay
dummy commit for tests
537d6a8
@rfay
Use /proc/1/fd/1 for redirect instead of pipe [skip ci]
e912d01
@rfay
Dummy commit to run tests
7d2a9bb
@rfay
Fix TestCmdLogs failure - logs should go to proc 1 stdout/err [skip ci]
8f72f80
@rfay
Dummy commit to run tests
f88c635
@rfay
Fix up TestCmdLogs
22dd8d9
@rfay
Independently start web-entrypoint + python so we get errors [skip ci]
9673ef0
@rfay
Let supervisord daemonize [skip ci]
b0d6e3c
@rfay
Don't start supervisord if already running [skip ci]
5fc3eb7
@rfay
Minor quote add in start-gunicorn.py [skip ci]
5788fea
@rfay
oops, add back in sites removed for debugging
7614321
@rfay
Change cleanup to t.Cleanup() in TestGetLocalHTTPResponse() [skip ci]
bc4be47
@rfay
Cleanup on TestValidTestSite
4f47098
@rfay
Remove TestChdir() because I try never to use it anyway
565c22d
@rfay rfay force-pushed the 20230417_presync_web_mutagen branch from f3f3015 to 0b33643 Compare April 22, 2023 18:10
@rfay rfay merged commit e0c89d6 into ddev:master Apr 23, 2023
14 checks passed
@rfay rfay deleted the 20230417_presync_web_mutagen branch April 23, 2023 12:57
@rfay rfay mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rfay