add link to "Testing a PR" to PR build #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
rfay
approved these changes
Apr 18, 2023
|
I wasn't sure how to test it. |
|
If you want to test in advance, check this out into your fork's master branch and create a PR on your fork. But we can do it the easy way if you don't. |
|
It worked!
|
|
Great! It's a small thing but helpful. Might be good to have @mattstein have a pass over that section of the docs, if he hasn't recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
"PR builds" automatically generate binaries for each platform. However, we don't offer any further help on what to do.
How This PR Solves The Issue
We have a section in the docs, Testing a PR.
This PR adds a link to the docs to help developers get started.
Release/Deployment Notes
I think something short and "simple" works best here. The docs should be "source of truth" and offer expanded details.