settings.php - Invert logic to reduce disk reads if non-ddev environment #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please add manual testing instructions, and please execute them yourself and report the results. https://ddev.readthedocs.io/en/latest/developers/building-contributing/#testing-a-pr |
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
rfay
approved these changes
Apr 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #4838
The Issue
How This PR Solves The Issue
It inverts the logic, thus on non-ddev environments, it will not read the disk unneeded.
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes