[docs] Add precomposed sponsor logos to readme [skip ci] #4850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
https://github.com/mattstein/ddev/tree/docs/readme-sponsors-svg looks great to me!
rfay
changed the title
|
Please pull whenever you fancy, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Related to #44 and #46, sponsors could be promoted with more care in several places.
How This PR Solves The Issue
This replaces individual sponsor logos in the readme with a programmatically precomposed SVG, so all logos are pulled from the ddev.com front end and hopefully easier to maintain.
GitHub doesn’t facilitate linking from embedded SVGs, but clicking on it will directly open the asset where the links do work.
While the dark mode presentation isn’t exactly stunning, it’s at least more uniform as a result:
Manual Testing Instructions
Examine the readme over here, I guess.
Automated Testing Overview
n/a
Related Issue Link(s)
Release/Deployment Notes
n/a