Shut down supervisord on start in case it's running #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
force-pushed
the
20230427_kill_supervisord
branch
4 times, most recently
from
b7c7eee
to
a8c5497
Compare
rfay
force-pushed
the
20230427_kill_supervisord
branch
from
83bf725
to
65aa4ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
We had intermittent failures in automated testing on TestCmdStart.
This seems to have been a result of the unusual behavior in that test: Pause all, then start all.
With the new start.sh setup, this could mean that the container wasn't being started from scratch, so supervisord was possibly already running.
The actual problem we saw was only with webserver_type=apache-fpm; apache2 not starting successfully, perhaps because it hasn't stopped properly.
How This PR Solves The Issue
supervisorctl shutdownat beginning of start.shManual Testing Instructions
Try
ddev startwith apache-fpm, and thenddev start.Try
ddev pauseandddev startAutomated Testing Overview
Related Issue Link(s)
Release/Deployment Notes