Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap diagnostic output into collapsed <details> block #4865

Merged
merged 9 commits into from
May 4, 2023

Conversation

MurzNN
Copy link
Contributor

@MurzNN MurzNN commented May 3, 2023

The Issue

We need to create a gist now to paste diagnostic information, that is too many actions for a regular user.

How This PR Solves The Issue

This fix should add the pre-filled text to the diagnostic field.

Manual Testing Instructions

Create a new issue and fill the diagnostic data.

Automated Testing Overview

Related Issue Link(s)

Fixes #4244

Release/Deployment Notes

@MurzNN MurzNN requested a review from a team as a code owner May 3, 2023 14:20
@rfay
Copy link
Member

rfay commented May 3, 2023

IIRC this approach doesn't work in bug report template, but please try it in your own repo or fork to make sure.

@MurzNN
Copy link
Contributor Author

MurzNN commented May 3, 2023

There was a whitespace problem, fixed now, here is the example bug: MurzNN#7
Please check.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is great. Minor suggestions you can accept (and preferably test in your fork too). I appreciate it. I think the last time this was attempted it didn't work out.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@rfay rfay requested a review from mattstein May 3, 2023 20:41
MurzNN and others added 5 commits May 4, 2023 08:54
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
Co-authored-by: Randy Fay <randy@randyfay.com>
@rfay rfay merged commit 765aebe into ddev:master May 4, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ddev issue template: Put diagnostic information inline into issues and hide under "details" collapsed block
3 participants