Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log location (supervisord) in several places #4873

Merged
merged 7 commits into from
May 5, 2023
Merged

Fix log location (supervisord) in several places #4873

merged 7 commits into from
May 5, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented May 4, 2023 •
edited by gitpod-io bot

The Issue

  • In docs and in the build for web_extra_daemons, the logs weren't being sent to the right place
  • In the hardened (prod) docker image, the newer gunicorn supervisord config wasn't even being included

How This PR Solves The Issue

  • Fix up those things
  • Remove the prod files as there was no reason for them to be duplicated

In general, this doesn't affect much; the logs issues are minor, and the prod image is rarely used.

Manual Testing Instructions

  • Run the prod image (better: Deploy it with ddev) and make sure /etc/supervisor has the gunicorn files.
  • Add a web_extra_daemons entry and verify that logs from the daemon are shown in ddev logs

Automated Testing Overview

No changes

@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited

Download the artifacts for this pull request:

See Testing a PR

@rfay
Copy link
Member Author

rfay commented May 4, 2023

Looks like the hardened/prod healthcheck is broken.

@rfay rfay force-pushed the 20230504_fix_log_in_web_extra_daemons branch from 6b6c49e to 1d6d10a Compare May 5, 2023 01:32
@rfay rfay marked this pull request as ready for review May 5, 2023 01:49
@rfay rfay requested review from a team as code owners May 5, 2023 01:49
@rfay rfay merged commit cd8d78a into ddev:master May 5, 2023
20 of 21 checks passed
@rfay rfay deleted the 20230504_fix_log_in_web_extra_daemons branch May 5, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstein mattstein mattstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfay @mattstein