Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for empty HTTP_EXPOSE and HTTPS_EXPOSE env variables (traefik only) #4888

Merged
merged 1 commit into from
May 9, 2023
Merged

check for empty HTTP_EXPOSE and HTTPS_EXPOSE env variables (traefik only) #4888

merged 1 commit into from
May 9, 2023

Conversation

hanoii
Copy link
Collaborator

@hanoii hanoii commented May 8, 2023 •
edited by gitpod-io bot

@hanoii hanoii requested a review from a team as a code owner May 8, 2023 16:49
rfay
rfay approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks!

@rfay rfay changed the title check for empty http(s) expose env variable check for empty HTTP_EXPOSE and HTTPS_EXPOSE env variables (traefik only) May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Download the artifacts for this pull request:

See Testing a PR

@rfay
Copy link
Member

rfay commented May 8, 2023

Please make sure to manually test this and show you results, and tell us how to manually test.

@hanoii
Copy link
Collaborator Author

hanoii commented May 8, 2023

I tried it locally but only by cherry-picking my changes into a local branch out of v1.26.1.

Trying to test on gitpod but for some reasoon is failing to start, getting that the health of the containers cannot be checked. It shouldn't be realted to this, but testing ddev on its own on gitpod too.

Steps would be:

  1. Make sure something is listening on port 8983 (nc -p 8983 -l?) on the host.
  2. ddev init a drupal 9 project (or any other)
  3. ddev get ddev/ddev-drupal9-solr
  4. ddev start should fail
  5. create a .ddev/docker-compose.zsolr.yaml file with:
# Addon overrides
services:
  solr:
    environment:
     - HTTP_EXPOSE=
  1. ddev start should work
  2. docker ps should show that no port is exposed for solr

@rfay
Copy link
Member

rfay commented May 8, 2023

Please test with the artifacts here (or by building), thanks!

@hanoii
Copy link
Collaborator Author

hanoii commented May 8, 2023 •
edited

I did test a local build, it worked as expected.

@rfay rfay merged commit e9218fd into ddev:master May 9, 2023
15 of 17 checks passed
@hanoii hanoii deleted the empty-http-expose-envvar branch August 4, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanoii @rfay