Fix gitpod failure to start, fixes #4889 #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
force-pushed
the
20230509_gitpod_output
branch
from
6fa4497
to
02b77bb
Compare
mattstein
approved these changes
May 10, 2023
rfay
force-pushed
the
20230509_gitpod_output
branch
from
34f8736
to
7e9e98a
Compare
rfay
force-pushed
the
20230509_gitpod_output
branch
from
7e9e98a
to
7e1c734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Due to apparent odd docker configuration, DDEV projects fail to start on gitpod
How This PR Solves The Issue
Instead of using the classic approach of writing to /proc/1/fd/1 to get info into docker logs, use a dedicated fifo.
TODO
bash -c "start.sh || kill 1", something like that.Manual Testing Instructions
Start a project on gitpod.
Make sure it works
Use
ddev logsto make sure expected info is there.Automated Testing Overview
No changes
Related Issue Link(s)
Release/Deployment Notes