Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for MariaDB 10.11 LTS #4902

Merged
merged 5 commits into from
May 13, 2023
Merged

Conversation

cngJo
Copy link
Contributor

@cngJo cngJo commented May 11, 2023

The Issue

Currently, the latest supported MariaDB Version to 10.8. The newest (LTS) version of MariaDB is 10.11.

Note: In #4894 are comments about only supporting MariaDB LTS Releases, that's why 10.9 and 10.10 are not added.

How This PR Solves The Issue

  • Add MariaDB 10.11 to containers/ddev-dbserver/Makefile
  • Add MariaDB 10.11 to allowed config options

Manual Testing Instructions

  • ddev config --database=mariadb:10.11 (New project, or delete project, or migrate)
  • Make sure it works

Automated Testing Overview

I'm not sure whether there are automated tests for changes like this. If so, I'd of course look into that and adapt them accordingly.

Related Issue Link(s)

Fixes #4894

Release/Deployment Notes

@cngJo cngJo requested review from a team as code owners May 11, 2023 18:48
@cngJo
Copy link
Contributor Author

cngJo commented May 11, 2023

I'm not sure about the changes in the docs.

It's currently phrased as

you can use nearly any MariaDB versions 5.5-10.8

but since currently all 10.x-10.8 versions are supported, I'm not sure whether a two Version gap still qualifies as "nearly all" Versions. Therefore, I've added the notice for 10.11 as

you can use nearly any MariaDB versions 5.5-10.8 or 10.11

Please let me know if that wording should be changed to something else.

Preview Docs: https://ddev--4902.org.readthedocs.build/en/4902/users/extend/database-types/


Maybe it makes sense to convert this sentence into a table of supported Database Versions.
When you are interested in such a change, I'd be happy to add such a table in a separate Pull Request ;)

@rfay
Copy link
Member

rfay commented May 12, 2023

Thanks!

This will need to have a new set of images pushed with a new tag. I'll get that going.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for taking it on. I pushed the necessary image, updated the image tag, and made a couple of small changes to docs and related. We'll see how the tests do!

@cngJo
Copy link
Contributor Author

cngJo commented May 12, 2023

Thank you for your help and Input regarding this change and the additional docs changes!

@rfay
Copy link
Member

rfay commented May 13, 2023

I tested this using a number of approaches and it seemed fine.

  • ddev debug migrate-database mariadb:10.11
  • ddev describe
  • ddev debug migrate database mariadb:10.4

I'm going to go ahead and pull it, but would appreciate it if you could run through the testing process on HEAD @cngJo , see https://ddev.readthedocs.io/en/latest/developers/building-contributing/#testing-latest-commits-on-head

@rfay rfay merged commit 7093d9c into ddev:master May 13, 2023
21 checks passed
@rfay
Copy link
Member

rfay commented May 13, 2023

Thanks so much for making this happen!

@cngJo
Copy link
Contributor Author

cngJo commented May 15, 2023

@rfay ran through your commands on a fresh build of HEAD locally and everything worked fine!

Thank you!

@cngJo cngJo deleted the feature/mariadb-lts branch May 15, 2023 04:29
@rfay
Copy link
Member

rfay commented May 15, 2023

Thanks for testing! Thanks for the initiative to make this happen and sort out what we should support in the future.

@mbomb007
Copy link
Contributor

@rfay Could we have a release with this feature, please?

@cngJo
Copy link
Contributor Author

cngJo commented Jul 18, 2023

@mbomb007

Could we have a release with this feature, please?

This change was included in v1.22.0-alpha3 and will be included in v1.22.0 which is feature complete since v1.22.0-beta4 from yesterday. At least when I read this tweet correctly.

So I guess we aren't far from the final v1.22.0 release. When you need MariaDB 10.11 earlier, you could install the latest v1.22.0-beta4. See #5015 for more information, how to install the beta release.

@rfay
Copy link
Member

rfay commented Jul 18, 2023

I'd sure appreciate if you'd test @mbomb007 , https://github.com/ddev/ddev/releases

@mbomb007
Copy link
Contributor

mbomb007 commented Jul 18, 2023

I installed DDEV in WSL2 with sudo apt install ddev. How do I switch versions to install a beta release?

@rfay
Copy link
Member

rfay commented Jul 18, 2023

The instructions are on the release, https://github.com/ddev/ddev/releases. On Linux, to get prereleases you have to use the script or use homebrew. Unfortunately we don't provide an apt repo for prereleases.

@mbomb007
Copy link
Contributor

I won't be able to look into testing it until next week probably.

@mattstein mattstein removed the request for review from a team July 18, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MariaDB LTS versions
3 participants