-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for MariaDB 10.11 LTS #4902
Conversation
I'm not sure about the changes in the docs. It's currently phrased as
but since currently all 10.x-10.8 versions are supported, I'm not sure whether a two Version gap still qualifies as "nearly all" Versions. Therefore, I've added the notice for
Please let me know if that wording should be changed to something else. Preview Docs: https://ddev--4902.org.readthedocs.build/en/4902/users/extend/database-types/ Maybe it makes sense to convert this sentence into a table of supported Database Versions. |
Thanks! This will need to have a new set of images pushed with a new tag. I'll get that going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thanks for taking it on. I pushed the necessary image, updated the image tag, and made a couple of small changes to docs and related. We'll see how the tests do!
Thank you for your help and Input regarding this change and the additional docs changes! |
I tested this using a number of approaches and it seemed fine.
I'm going to go ahead and pull it, but would appreciate it if you could run through the testing process on HEAD @cngJo , see https://ddev.readthedocs.io/en/latest/developers/building-contributing/#testing-latest-commits-on-head |
Thanks so much for making this happen! |
@rfay ran through your commands on a fresh build of Thank you! |
Thanks for testing! Thanks for the initiative to make this happen and sort out what we should support in the future. |
@rfay Could we have a release with this feature, please? |
This change was included in So I guess we aren't far from the final |
I'd sure appreciate if you'd test @mbomb007 , https://github.com/ddev/ddev/releases |
I installed DDEV in WSL2 with |
The instructions are on the release, https://github.com/ddev/ddev/releases. On Linux, to get prereleases you have to use the script or use homebrew. Unfortunately we don't provide an apt repo for prereleases. |
I won't be able to look into testing it until next week probably. |
The Issue
Currently, the latest supported MariaDB Version to 10.8. The newest (LTS) version of MariaDB is 10.11.
Note: In #4894 are comments about only supporting MariaDB LTS Releases, that's why 10.9 and 10.10 are not added.
How This PR Solves The Issue
containers/ddev-dbserver/Makefile
Manual Testing Instructions
ddev config --database=mariadb:10.11
(New project, or delete project, or migrate)Automated Testing Overview
I'm not sure whether there are automated tests for changes like this. If so, I'd of course look into that and adapt them accordingly.
Related Issue Link(s)
Fixes #4894
Release/Deployment Notes