Remove unused package spf13/viper and dependencies from vendor, etc.

[gilbertsoft]

The Issue

The usage of package github.com/spf13/viper was removed with f24e8e5 6 years ago but one line was forgotten which had no effect anymore.

How This PR Solves The Issue

This PR removes that last line and the package with its dependencies.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

Sure looks good to me! Amazing.

[gilbertsoft]

Sure looks good to me! Amazing.

Reduces the binary size for almost 2MB :)

[rfay]

That's weird, the binary shouldn't have been affected, but I guess because of that one single use!

[gilbertsoft]

That's weird, the binary shouldn't have been affected, but I guess because of that one single use!

Yes it does, that's a known problem of Viper. In our case not that big because we already import some dependencies which Viper would do. See also https://github.com/knadh/koanf#alternative-to-viper and https://github.com/knadh/koanf/wiki/Comparison-with-spf13-viper

[rfay]

Thanks for this! Is it going to mess up your vendor dir for the amplitude patch? Almost pulled, then thought about that. Would you rather do it after that goes in?

[gilbertsoft]

Thanks for this! Is it going to mess up your vendor dir for the amplitude patch? Almost pulled, then thought about that. Would you rather do it after that goes in?

No, should do any harm. You can merge at any time.