[tests only] dockerutils_test TestMain should only delete existing test container #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In a recent update the logic was changed in the testMain of dockerutils_test; it may or may not have to clean up the test container, but it should use the correct test container.
I was seeing this output sometimes in tests:
[580](https://github.com/ddev/ddev/actions/runs/4990360031/jobs/8935458261?pr=4866#step:9:581)time="2023-05-16T09:50:34Z" level=error msg="-- FAIL: dockerutils_test failed to remove test container: No such container: 3578dd127b77350566d800ec43c2ac63485d8ebedcbccb5bfa4f3ce390e15bb6"