Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate "build" from "up" stages in DDEV Start() #4919

Merged
merged 6 commits into from
May 22, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented May 16, 2023

The Issue

People sometimes struggle with debugging .web-build/Dockerfile.* items because it doesn't give good output unless there's an error.

How This PR Solves The Issue

  • With export DDEV_VERBOSE=true ddev start shows the output of the build stage and also the full output of the "up" stage, including start.sh, etc.
  • ddev debug refresh always shows the output of the build stage.
  • Added DDEV_VERBOSE=true to the troubleshooting.md page.
  • Added unconditional timestamp to util.Debug() output

TODO

  • Change docs to say DDEV_VERBOSE shows build info
  • DDEV_VERBOSE add to docs about debugging Dockerfile

Manual Testing Instructions

  • export DDEV_VERBOSE=true && ddev start
  • Compare start time to previous versions

@github-actions
Copy link

github-actions bot commented May 16, 2023

@rfay rfay force-pushed the 20230516_separate_compose_build_start branch from 88bf5ec to caff8f2 Compare May 20, 2023 13:26
@rfay rfay marked this pull request as ready for review May 20, 2023 17:12
@rfay rfay requested review from a team as code owners May 20, 2023 17:12
@rfay
Copy link
Member Author

rfay commented May 20, 2023

I compared ddev start times with this against upstream/master and I don't believe it does any harm.

@rfay rfay requested a review from gilbertsoft May 20, 2023 17:15
@rfay rfay changed the title Experimental: Separate "build" from "up" stages in DDEV Start() Separate "build" from "up" stages in DDEV Start() May 20, 2023
@rfay rfay merged commit e99e00b into ddev:master May 22, 2023
19 checks passed
@rfay rfay deleted the 20230516_separate_compose_build_start branch May 22, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant