Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete FUNDING.yml #4929

Merged
merged 1 commit into from
May 19, 2023
Merged

Delete FUNDING.yml #4929

merged 1 commit into from
May 19, 2023

Conversation

gilbertsoft
Copy link
Member

@gilbertsoft gilbertsoft commented May 18, 2023 •
edited by gitpod-io bot

Use FUNDING.yml from the default community health file instead (https://github.com/ddev/.github/blob/main/FUNDING.yml)

@gilbertsoft
Delete FUNDING.yml
e19d834 
Use FUNDING.yml from the default community health file instead (https://github.com/ddev/.github/blob/main/FUNDING.yml)
@gilbertsoft gilbertsoft requested a review from a team as a code owner May 18, 2023 22:23
rfay
rfay requested changes May 18, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last I looked, the org one wasn't working. For example, see https://github.com/ddev/ddev-platformsh or https://github.com/ddev/ddev-addon-template - they don't have the funding info. So I don't think we can remove this.

I guess we should ask their support about it.

@gilbertsoft
Copy link
Member Author

Last I looked, the org one wasn't working. For example, see https://github.com/ddev/ddev-platformsh or https://github.com/ddev/ddev-addon-template - they don't have the funding info. So I don't think we can remove this.

I guess we should ask their support about it.

Doesn't work there because sponsoring isn't enabled in these repos. Here it works fine https://github.com/ddev/localdev.foundation

@gilbertsoft
Copy link
Member Author

Activated for https://github.com/ddev/ddev-addon-template now and works too

@gilbertsoft gilbertsoft requested a review from rfay May 18, 2023 22:32
@gilbertsoft
Copy link
Member Author

Btw fixed the second link before which wasn't a link and has broken custom links.

@gilbertsoft
Copy link
Member Author

Sposoring should now be active in all repos.

rfay
rfay approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

@rfay rfay merged commit 57fa766 into master May 19, 2023
7 of 8 checks passed
@rfay rfay deleted the gilbertsoft-patch-1 branch May 19, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbertsoft @rfay