Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run wsl2-docker-desktop on master #4930

Merged
merged 1 commit into from
May 19, 2023
Merged

Only run wsl2-docker-desktop on master #4930

merged 1 commit into from
May 19, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented May 18, 2023 •
edited by gitpod-io bot

The Issue

WSL2 Docker Desktop crashes so often that it doesn't make sense to run it for every PR/commit. Let's just run it against master.

@rfay rfay requested a review from a team as a code owner May 18, 2023 22:28
@rfay rfay requested a review from gilbertsoft May 18, 2023 22:29
gilbertsoft
gilbertsoft approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@gilbertsoft gilbertsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sad we have to disable it.

@rfay rfay merged commit 953ab20 into ddev:master May 19, 2023
7 of 8 checks passed
@rfay rfay deleted the 20230518_wsl2_docker_desktop_only_master branch May 19, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbertsoft gilbertsoft gilbertsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfay @gilbertsoft