Allow add-ons to declare dependencies, fixes #4717 #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
mattstein
requested changes
May 23, 2023
Co-authored-by: Matt Stein <m@ttste.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
dependencieskey to install.yamlddev get, if the target add-on requires a dependency, check before allowing get (and ask for dependency to be installed if not)ddev get --removeexplain to people that the dependency might need to be removed.Manual Testing Instructions
Try out these steps. You'll likely want a manually checked out add-on to add
dependenciesto.Automated Testing Overview
Added TestCmdGetDependencies