Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests only] Fix TestPHPOverrides for Windows Mutagen, fixes #4875 #4968

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 9, 2023

The Issue

Trying to make tests work on Windows Mutagen again.

How This PR Solves The Issue

  • It seems that for Windows, the app.Start() didn't cause a mutagen flush in some situations. Adding the flush seems to make TestPHPOverrides work OK.
  • Turned off macos-nfs for PRs, which will save some testing resources.

@rfay rfay requested a review from a team as a code owner June 9, 2023 21:04
@rfay rfay changed the title Try to fix TestPHPOverrides for Windows Mutagen, for #4875 [tests only] Try to fix TestPHPOverrides for Windows Mutagen, for #4875 Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

@rfay rfay changed the title [tests only] Try to fix TestPHPOverrides for Windows Mutagen, for #4875 [tests only] Fix TestPHPOverrides for Windows Mutagen, fixes #4875 Jun 9, 2023
@rfay rfay merged commit 9fde770 into ddev:master Jun 10, 2023
18 of 19 checks passed
@rfay rfay deleted the 20230609_windows_only_on_master branch June 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant