Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Show details about GitHub PAT for package management #4971

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 12, 2023

The Issue

I couldn't figure out where the (expired) package management PAT was used. But it was already documented.

How This PR Solves The Issue

Give more context about it.

@rfay rfay requested a review from a team as a code owner June 12, 2023 22:48
@mattstein
Copy link
Sponsor Collaborator

Is this the formatting you intended, @rfay?

Screen Shot 2023-06-13 at 04 02 43 PM@2x

I’m usually not a fan of “see X” style links that could use more contextual anchor text, but escaping the link itself seems downright reader-hostile since they’ll have to copy and paste it.

@rfay
Copy link
Member Author

rfay commented Jun 14, 2023

I think it actually is the right formatting. Hard to work with though. The URL to the PAT can't pass docs check because it's not a public URL, that's why it's back-quoted. The name of the token is "Package management token see ... url"

So very awkward, but probably what I was trying to accomplish.

Definitely reader-hostile. Very, very small audience.

@mattstein
Copy link
Sponsor Collaborator

Oh I see. Awkward but intentional. No more questions from me, then!

@rfay rfay merged commit 177b3bf into master Jun 14, 2023
11 of 12 checks passed
@rfay rfay deleted the 20230612_docs_PAT_package_management branch June 14, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants