Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix link to TYPO3 docs #4988

Merged
merged 1 commit into from
Jun 15, 2023
Merged

[docs] Fix link to TYPO3 docs #4988

merged 1 commit into from
Jun 15, 2023

Conversation

gilbertsoft
Copy link
Member

No description provided.

@gilbertsoft gilbertsoft marked this pull request as ready for review June 15, 2023 19:12
@gilbertsoft gilbertsoft requested a review from a team as a code owner June 15, 2023 19:12
@@ -125,4 +125,4 @@ baseVariants:
condition: 'applicationContext == "Development/DDEV"'
```

See also [TYPO3 Documentation](https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/SiteHandling/BaseVariants.html).
See also [TYPO3 Documentation](https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ApiOverview/SiteHandling/BaseVariants.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to make this permanent so it will always track properly? Seems like 12.4 will be very fragile very fast.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, 12.4 is the latest version for the next one and a half years and main does not work currently. But can have a talk to the docs team what's wrong here so we also can stay on main. But master is outdated anyway in the meantime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering of main branch didn't work but up again. We finally can change to main.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me then. Please do check with team about whether they'll manage a main branch etc.

@rfay rfay merged commit 3c8bd59 into ddev:master Jun 15, 2023
8 checks passed
@rfay rfay deleted the docs/fix-link branch June 15, 2023 20:17
@rfay
Copy link
Member

rfay commented Jun 15, 2023

I saw it was breaking existing tests (why you did it I assume) so pulled it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants