-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix link to TYPO3 docs #4988
Conversation
@@ -125,4 +125,4 @@ baseVariants: | |||
condition: 'applicationContext == "Development/DDEV"' | |||
``` | |||
|
|||
See also [TYPO3 Documentation](https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/SiteHandling/BaseVariants.html). | |||
See also [TYPO3 Documentation](https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ApiOverview/SiteHandling/BaseVariants.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to make this permanent so it will always track properly? Seems like 12.4 will be very fragile very fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, 12.4 is the latest version for the next one and a half years and main does not work currently. But can have a talk to the docs team what's wrong here so we also can stay on main. But master is outdated anyway in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendering of main branch didn't work but up again. We finally can change to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with me then. Please do check with team about whether they'll manage a main branch etc.
I saw it was breaking existing tests (why you did it I assume) so pulled it. |
No description provided.