Remove PhpMyAdmin/dba from DDEV core, fixes #3534 #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
gilbertsoft
requested changes
Jun 18, 2023
mattstein
requested changes
Jun 19, 2023
rfay
force-pushed
the
20230615_remove_dba
branch
from
8b0a428
to
8b93e51
Compare
rfay
commented
Jun 25, 2023
Co-authored-by: Matt Stein <m@ttste.in> Co-authored-by: Gilbertsoft <25326036+gilbertsoft@users.noreply.github.com>
rfay
force-pushed
the
20230615_remove_dba
branch
from
c8a2138
to
d6d4b9b
Compare
|
Rebased, should be close to ready. |
Co-authored-by: Gilbertsoft <25326036+gilbertsoft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
After long consideration it was decided to remove PhpMyAdmin from DDEV Core because there are so many other database browsers that people use, including SequelAce and so many others.
PhpMyAdmin is now available at
ddev get ddev/ddev-phpmyadminTODO:
How This PR Solves The Issue
Remove it all
Manual Testing Instructions
dbaandphpmyadmindon't come upddev launch -pdoes the right thing and directs people to solution.Automated Testing Overview
Removed lots of things.
Release/Deployment Notes
Have to tell people!