add DDEV_DATABASE_FAMILY variable, fixes #4954
#4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Look at you go! |
|
Sorry for the noise. Finally added a "GO" addon to VScode for proper syntax highlighting etc. |
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
requested changes
Jun 16, 2023
There was a problem hiding this comment.
Thanks!
- Still needs to be added to docs (custom_commands.md) If you find other things missing there, OK to add.
- Still needs to be added to test, TestEnvironmentVariables (you may find that some other things like DDEV_DATABASE are missing from test, OK to add.
tyler36
force-pushed
the
20230616_add_DDEV_DATABASE_PROTOCOL_variable
branch
2 times, most recently
from
ba40e3c
to
1d0378c
Compare
gilbertsoft
requested changes
Jun 19, 2023
OK. That was the piece I was missing. |
Not sure why the golint test is failing. |
You just miss two spaces at the mentioned line. |
gilbertsoft
requested changes
Jun 19, 2023
gilbertsoft
requested changes
Jun 19, 2023
gilbertsoft
changed the title
DDEV_DATABASE_PROTOCOL variableDDEV_DATABASE_FAMILY variable
mattstein
approved these changes
Jun 19, 2023
gilbertsoft
approved these changes
Jun 20, 2023
rfay
changed the title
DDEV_DATABASE_FAMILY variableDDEV_DATABASE_FAMILY variable for #4954
rfay
approved these changes
Jun 21, 2023
Resolve "Error: File is not gofmt-ed with -s (gofmt)" Co-authored-by: Gilbertsoft <25326036+gilbertsoft@users.noreply.github.com>
tyler36
force-pushed
the
20230616_add_DDEV_DATABASE_PROTOCOL_variable
branch
from
0203dcc
to
cdc58ff
Compare
|
Rebase |
rfay
changed the title
DDEV_DATABASE_FAMILY variable for #4954DDEV_DATABASE_FAMILY variable, fixes #4954
|
Congratulations and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I want to generate database resource URLs for use in code and DDEV addons.
Currently, DDEV exposes
DDEV_DATABASEwhich isapp.Database.Type + ":" + app.Database.Version,.This is difficult to use because it must be parsed, and converted (MariaDB uses
mysqlprotocol).How This PR Solves The Issue
This PR adds a new environmental variable:
DDEV_DATABASE_FAMILYmysqlpostgresif database ispostgresManual Testing Instructions
ddev exec set | grep DDEV_DATABASEto check currently set database variablesAutomated Testing Overview
Related Issue Link(s)
Fixes #4954
Release/Deployment Notes