Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message in ddevapp.go #4994

Merged
merged 3 commits into from
Jun 18, 2023

Conversation

rpkoller
Copy link
Collaborator

@rpkoller rpkoller commented Jun 16, 2023

A small wording change to the "ddev ssh failed" error message. I only wonder in regards of styling if "styling" should be upper case. Usually it is the rule to use upper case after periods and colons?

The Issue

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

A small change wording change to the "ddev ssh failed" error message. I only wonder in regards of styling if "styling" should be upper case. Usually it is the rule to use upper case after periods and colons?
@rpkoller rpkoller requested a review from a team as a code owner June 16, 2023 22:36
@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor suggestion.

pkg/ddevapp/ddevapp.go Outdated Show resolved Hide resolved
Co-authored-by: Randy Fay <randy@randyfay.com>
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfay rfay merged commit ed3648f into ddev:master Jun 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants