-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update custom-commands.md adding DDEV_UID & DDEV_GID #4997
[docs] Update custom-commands.md adding DDEV_UID & DDEV_GID #4997
Conversation
Adding DDEV_UID and DDEV_GID in the list of variables available on the host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please rebase your branch, looks like you did not use latest master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@gilbertsoft uhhhh i haven't done quick one-off pull requests with just small changes in a text file directly via the github interface very often. so far i was under the impression that forks are kept up to date automatically in contrast to the command line where you run Update: or wait a second. would it be ok instead of looking for a rebase button simply update the branch in my fork? so far i only updated the main branch. but i went ahead into the branch for this PR and clicked |
@rpkoller If you used the web UI to create this patch, it used the latest master version, and created a new branch for you based on upstream/master. The problem is that you in the meantime had another PR pulled, which changed the underlying docs file. So now you have to rebase and solve the conflicts. You can also do that in the web UI, but I find that kind of hard. There are many merge conflict resolution techniques, you'll want to look at them. If you use vscode I imagine it has one. This is a very easy one to learn rebasing on, resolving conflicts, so may be worth your time. A lazy person could just do the PR over again. A less lazy person could just check out the branc, There are many ways to study the conflicts, one easy one is to click this button, ![]() But it will be a good exercise for you to learn how to rebase and solve conflicts, and this is a really easy one to do it on. |
Oh ok. when i checked the variant i suggested to go back to my ddev fork and into the corresponding branch there i would have the option to update the branch but that would drop/delete one commit (supposedly the one i did). but i would go with your suggested approach @rfay and go via the resolve conflicts button. but i suppose the cleanest approach for that is to copy the two line i'Ve added in this PR and copy them from the PR block down into the mast block and then delete the PR block and the dividers <<<<<, ==== and >>>>>. i think that would be the cleanest approach correct? update: ahhh the |
Thanks! We are able to merge now, conflicts resolved :) |
Another chance to practice your conflict resolution, thanks. This is a result of your two PRs touching the same area. It probably would have been easier for you to fix both things in one PR. We generally all avoid that but this would have been a good place to relax about it. |
yep true, i agree. but hope the conflicts are fixed now. |
The docs test failure is an upstream problem, not from this PR. See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, but after the earlier discussion, do you want those periods at the end of each of these?
Updated to pick up the upstream test fix, make sure you pull before working on it. |
At first i thought it was a good idea and i wanted to do that within the consistency issue. but i've dropped that idea in #4998 (comment) and agreed to @gilbertsoft . @mattstein also agreed to his point #4998 (comment). so this issue would be ready now that the tests are green after you upstream fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this. You can just commit both of these by clicking the buttons.
the two periods got removed that accidentally slipped in again. Co-authored-by: Randy Fay <randy@randyfay.com>
Adding DDEV_UID and DDEV_GID in the list of variables available on the host
The Issue
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes