feat: allow multiple upload dirs, fixes #4190, fixes #4796, fixes #5047

[gilbertsoft]

The Issue

• Single upload_dir is too limiting, doesn't work for lots of CMSs, make it upload_dirs #4190
• upload_dir should be able to be set to empty to prevent bind-mounting #4796
• Add new item to ddev debug capabilities #5047

How This PR Solves The Issue

A new config property upload_dirs is introduced to hold more than one upload dir. Existing config upload_dir is migrated to the new config and removed from the projects afterwards. For project types which do not predefine a default upload dir like php the warning about the missing upload dir can be disabled by setting upload_dirs: false which is also mentioned in the warning message.

Manual Testing Instructions

• upload_dir is migrated to upload_dirs
• multiple dirs can be set
• import-files works correctly when importing in a upload dir using the --target flag
• configuration with ddev config works properly, using --upload-dirs and --uplod-dir flags

Automated Testing Overview

Related Issue Link(s)

• Add new item to ddev debug capabilities #5047

Release/Deployment Notes

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

All the permutations I've tried now seem to work just fine, looking great, thanks!

[rfay]

We can ask the Craft CMS folks to test the prerelease, doesn't have to be done before this is merged.

[gilbertsoft]

pull-push tests succeeded https://github.com/ddev/ddev/actions/runs/5426930505/jobs/9869609829

[rfay]

From @mattstein about how to test Craft CMS upload_dir:

I never used the upload_dir feature because it seemed kind of old school and I wasn’t sure it’d get me anything. Craft’s editor-managed files are called Assets, and Assets live in Volumes that sit on top of filesystems that can be local folders, object storage, or anything with a Flysystem adapter.

I’m not sure what the feature should do, but to test it with Craft—assuming local Asset Volumes with locally-stored files—you’d want to create a handful of Volumes + filesystems and visit Assets in the control panel to be sure you can upload files to each one.

https://craftcms.com/docs/4.x/assets.html#volumes

If you sync new files into the local folders, or delete any, you’ll need to have Craft update its indexes:

https://craftcms.com/docs/4.x/assets.html#updating-asset-indexes

[gilbertsoft]

Investigated the failure and the reason was that some of the tests use an empty docroot which made the new ../private upload dir for Drupal invalid. Therefor added a validation of the upload dirs to be located in the project root or an error is shown. Last commit disabled the private dir again like discussed.

[rfay]

Rebased to re-run tests and fixed linting error in drupal.go.

Recommend using pre-push hook, https://github.com/ddev/ddev/tree/master/.githooks - maybe we don't have that in the docs?