Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump docker-compose to 2.20.0 #5006

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 21, 2023

The Issue

Docker-compose 2.20.0 is out

How This PR Solves The Issue

Run tests to try it.

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

@gilbertsoft gilbertsoft changed the title Bump docker-compose to 2.19.0 build: bump docker-compose to 2.19.0 Jun 28, 2023
@rfay
Copy link
Member Author

rfay commented Jun 29, 2023

I don't think we're going to be able to sort this out before DDEV v1.22.0 release. I'm hoping that a future version of compose will recognize and solve this.

However, there are some worthy tests changed here that should be pushed up.

@rfay
Copy link
Member Author

rfay commented Jun 29, 2023

@rfay rfay changed the title build: bump docker-compose to 2.19.0 build: bump docker-compose to 2.19.1 Jun 29, 2023
@rfay
Copy link
Member Author

rfay commented Jun 29, 2023

Compose 2.19.1 claims to fix the "container not connected to network" error, so trying that one.

@rfay rfay force-pushed the 20230621_compose_2.19.0 branch 2 times, most recently from 1b1118f to e770128 Compare June 30, 2023 15:30
@rfay
Copy link
Member Author

rfay commented Jul 5, 2023

Closing, will reopen when another compose release comes along.

@rfay rfay closed this Jul 5, 2023
@rfay rfay reopened this Jul 5, 2023
@rfay
Copy link
Member Author

rfay commented Jul 5, 2023

Oh, forgot there are some useful things in here that should be picked out.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 11, 2023
@rfay rfay changed the title build: bump docker-compose to 2.19.1 build: bump docker-compose to 2.20.0 Jul 11, 2023
@rfay
Copy link
Member Author

rfay commented Jul 11, 2023

docker-compose 2.20.0 came out today, may solve the problems we had. Trying it out.

@rfay rfay marked this pull request as ready for review July 11, 2023 18:20
@rfay rfay requested review from a team as code owners July 11, 2023 18:20
@rfay rfay requested a review from gilbertsoft July 11, 2023 18:21
@rfay rfay merged commit c5f2d0b into ddev:master Jul 11, 2023
33 checks passed
@rfay rfay deleted the 20230621_compose_2.19.0 branch July 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant