Make sure InternetDetectiontimeout is a reasonable value #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In
the logic that forces a reasonable value for InternetDetectionTimeout was lost. And many of the test runners had that value set to 0, so we got lots of failures, for example TestEnvironmentVariables in https://buildkite.com/ddev/ddev-macos-amd64-mutagen/builds/4489#0188ef4b-872a-4bc7-a6b0-cbddbc269697
How This PR Solves The Issue
Manual Testing Instructions
internet_detection_timeout_ms: 0- if that is happening somewhere we have another bug.ddev config global- it should show 3000.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes