[tests only] Improve TestRouterPortsCheck random failure, limit use of TestNodeJSVersions #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
rfay
changed the title
|
Download the artifacts for this pull request:
See Testing a PR |
|
TestProjectPortsOverride seems to have the exact same problem (Colima) likely for exact same reason. |
rfay
commented
Jun 26, 2023
pkg/ddevapp/ddevapp_test.go
Outdated
| }, | ||
| } | ||
|
|
||
| containerID, out, err := dockerutil.RunSimpleContainer(versionconstants.GetWebImage(), t.Name()+"occupyport", nil, []string{}, []string{}, []string{"testnfsmount" + ":/nfsmount"}, "", false, true, nil, portBinding) |
There was a problem hiding this comment.
This must have a dockerutil.WaitContainer() or equivalent
rfay
force-pushed
the
20230625_fix_router_ports_test
branch
from
0519a35
to
2c37b01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
TestRouterPortsCheck fails often, especially on colima slow Github actions test
TestNodeJSVersions often fails due to upstream problems or network problems. Don't test it in most places.
How This PR Solves The Issue