Optimize output of debug instrumentation flush, fixes #5023 #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbertsoft
force-pushed
the
task/optimize-debug-instrumentation-flush
branch
from
ac06c0a
to
a5a81fe
Compare
|
Instead of the EOF warning a propper message is now printed if the cache is empty |
gilbertsoft
force-pushed
the
task/optimize-debug-instrumentation-flush
branch
from
a5a81fe
to
2dc928f
Compare
|
Download the artifacts for this pull request:
See Testing a PR |
gilbertsoft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
#5023
How This PR Solves The Issue
Because the flush method of Amplitide has no return value we do not know if events are subitted or not. Only way around is to let the Amplitude logger print some messages.
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes