Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enforce commit message convention, fixes #5037 [skip ci] #5038

Merged
merged 1 commit into from
Jul 1, 2023
Merged

ci: enforce commit message convention, fixes #5037 [skip ci] #5038

merged 1 commit into from
Jul 1, 2023

Conversation

gilbertsoft
Copy link
Member

@gilbertsoft gilbertsoft commented Jun 28, 2023 •
edited by gitpod-io bot

@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited

Download the artifacts for this pull request:

See Testing a PR

@rfay
Copy link
Member

rfay commented Jun 28, 2023

Please make sure to lead the docs (and error messages from github actions) with several examples of valid titles. Most of us can't read through the requirements, we just want to do it right. Examples will help a lot.

@gilbertsoft gilbertsoft force-pushed the ci/enforce-commit-message-convention branch 4 times, most recently from 0cb407b to d0c32ec Compare June 30, 2023 13:01
@gilbertsoft gilbertsoft marked this pull request as ready for review June 30, 2023 13:20
@gilbertsoft gilbertsoft requested review from a team as code owners June 30, 2023 13:20
rfay
rfay requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'm concerned that we haven't run this on master yet, have you run these on master on your fork? If not, please experiment a bit on your fork with these on master.

.github/pr-labeler.yml Show resolved Hide resolved
.github/workflows/pr-check.yml Outdated Show resolved Hide resolved
docs/content/developers/building-contributing.md Outdated Show resolved Hide resolved
docs/content/developers/building-contributing.md Outdated Show resolved Hide resolved
docs/content/developers/building-contributing.md Show resolved Hide resolved
@gilbertsoft gilbertsoft force-pushed the ci/enforce-commit-message-convention branch 2 times, most recently from c0f51a8 to 7af361d Compare June 30, 2023 16:44
rfay
rfay approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

Please make sure to test to your satisfaction on your fork before pulling.

@gilbertsoft gilbertsoft force-pushed the ci/enforce-commit-message-convention branch from 7af361d to ae92fc8 Compare June 30, 2023 17:09
@gilbertsoft
Copy link
Member Author

Ready to be merged once @mattstein approved. Tested with Randy on my cloned repo and works like expected. Next step will be prepare release drafts based on the new labels.

@gilbertsoft gilbertsoft changed the title ci: enforce commit message convention, fixes #5037 ci: enforce commit message convention, fixes #5037 [skip ci] Jun 30, 2023
@rfay rfay merged commit eb68101 into ddev:master Jul 1, 2023
5 checks passed
@rfay rfay deleted the ci/enforce-commit-message-convention branch July 1, 2023 17:54
@mattstein mattstein removed the request for review from a team July 4, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbertsoft @rfay