Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: stop testing TestDdevFullSiteSetup on Windows/Colima [skip ci] #5041

Merged

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 28, 2023

The Issue

Traditional Windows and Colima testing are very slow and TestDdevFullSiteSetup is particularly problematic with both.

How This PR Solves The Issue

We don't need TestDdevFullSiteSetup on Windows/Colima. Stop testing it

Future:

For ddevapp package, we could easily change the TestMain to skip certain tests automatically based on some general criteria instead of doing one-off changes like this.

@rfay rfay requested a review from a team as a code owner June 28, 2023 18:39
@rfay
Copy link
Member Author

rfay commented Jun 28, 2023

Interestingly enough, https://buildkite.com/ddev/ddev-windows-mutagen/builds/4090#01890347-bfd6-4bba-808d-fc93bf430a6c also failed in TestDdevFullSiteSetup on a different test runner.

@rfay rfay merged commit b745b5f into ddev:master Jun 28, 2023
2 checks passed
@rfay rfay deleted the 20230628_disable_windows_TestDdevFullSiteSetup branch June 28, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant