-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refresh colima/lima/homebrew github caches, docker build cache #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
test: refresh colima/lima/homebrew github caches [skip ci]
test: refresh colima/lima/homebrew github caches, docker build cache [skip ci]
Jun 28, 2023
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
test: refresh colima/lima/homebrew github caches, docker build cache [skip ci]
test: refresh colima/lima/homebrew github caches, docker build cache
Jun 29, 2023
3 tasks
This seems to have done well,
|
gilbertsoft
reviewed
Jun 30, 2023
@@ -39,14 +39,5 @@ jobs: | |||
uses: golangci/golangci-lint-action@v3 | |||
with: | |||
version: latest | |||
args: --timeout=30m --disable-all --enable=gofmt --enable=govet --enable=revive --enable=errcheck --enable=staticcheck --enable=ineffassign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks bit high, but maybe good to start with...
gilbertsoft
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I'm seeing failures in colima of the Traefik router healthcheck coming up; in other environments this has meant the build cache is messy, or that's the best I've been able to figure out.
How This PR Solves The Issue
-built
images at start of testManual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes