Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refresh colima/lima/homebrew github caches, docker build cache #5043

Merged
merged 10 commits into from
Jun 30, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jun 28, 2023

The Issue

I'm seeing failures in colima of the Traefik router healthcheck coming up; in other environments this has meant the build cache is messy, or that's the best I've been able to figure out.

How This PR Solves The Issue

  • New cache for homebrew and colima/lima.
  • Clean docker build cache and -built images at start of test
  • Destroy any existing containers before starting test
  • Add healthcheck history to the output of many tests for debugging

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay changed the title test: refresh colima/lima/homebrew github caches [skip ci] test: refresh colima/lima/homebrew github caches, docker build cache [skip ci] Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

@rfay rfay changed the title test: refresh colima/lima/homebrew github caches, docker build cache [skip ci] test: refresh colima/lima/homebrew github caches, docker build cache Jun 29, 2023
@rfay
Copy link
Member Author

rfay commented Jun 29, 2023

This seems to have done well,

  • Add router healthcheck into the output when we fail to become ready in test
  • Increase timeout on golanci-lint check

@rfay rfay marked this pull request as ready for review June 30, 2023 03:04
@rfay rfay requested a review from a team as a code owner June 30, 2023 03:04
@rfay rfay requested a review from gilbertsoft June 30, 2023 03:04
@@ -39,14 +39,5 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
version: latest
args: --timeout=30m --disable-all --enable=gofmt --enable=govet --enable=revive --enable=errcheck --enable=staticcheck --enable=ineffassign
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks bit high, but maybe good to start with...

@gilbertsoft gilbertsoft merged commit 1008b44 into ddev:master Jun 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants