docs: improve additional-hostnames.md #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed confusing string quotes that doesn't work in the config and example of console command that adds the hostnames for you.
rfay
changed the title
|
I don't know why quote marks around the hostname entries wouldn't work... that's standard yaml. Please check again. |
gilbertsoft
changed the title
gilbertsoft
requested changes
Jun 30, 2023
gilbertsoft
approved these changes
Jun 30, 2023
mattstein
requested changes
Jul 4, 2023
There was a problem hiding this comment.
Sorry for the wait! Added a suggestion to help with the flow and connect examples.
Two more things I can’t offer as suggestions, if you’re willing to update them:
-
The opening sentence should probably describe both methods before illustrating them:
You can add hostnames to a project by editing its config file or using the
ddev configcommand.Use the
additional_hostnamesarray in.ddev/config.yaml: -
Add
yamlto the config snippets for syntax highlighting. (```yaml)
mattstein
reviewed
Jul 4, 2023
Co-authored-by: Matt Stein <m@ttste.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed confusing string quotes that doesn't work in the config and example of console command that adds the hostnames for you.
The Issue
Quotes around the hostnames didn't work for me.
How This PR Solves The Issue
Removes the quotes from the text and suggests a console command
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes