fix: make sure router gets built on start, for #5040

[rfay]

The Issue

• DDEV upgrade cleanup: flush and remove existing mutagen sessions #5040

We've been having trouble on upgrades with ddev-router not getting rebuilt; it turns out the docker-compose command didn't have --build in there.

How This PR Solves The Issue

Add --build so router gets rebuilt if it already existed.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

This solved @rpkoller 's problem, this alone, was tested on misbehaving system.

[rpkoller]

I hope that is the correct bit @rfay asked for. but that is the output we had debugging the problem on my computer.

in ~/.ddev/router-build we did cat Dockerfile

#ddev-generated

ARG BASE_IMAGE
FROM $BASE_IMAGE


RUN apk add bash curl htop vim
WORKDIR /mnt/ddev-global-cache/traefik
COPY /traefik_healthcheck.sh /healthcheck.sh

and then the following command inspecting the router output:

$> docker inspect --format "{{json .State.Health }}" ddev-router
{"Status":"unhealthy","FailingStreak":1003,"Log":[{"Start":"2023-06-30T21:49:05.202976174Z","End":"2023-06-30T21:49:05.321276965Z","ExitCode":127,"Output":"/bin/sh: /healthcheck.sh: not found\n"},{"Start":"2023-06-30T21:49:06.328373341Z","End":"2023-06-30T21:49:06.445561549Z","ExitCode":127,"Output":"/bin/sh: /healthcheck.sh: not found\n"},{"Start":"2023-06-30T21:49:07.450499216Z","End":"2023-06-30T21:49:07.576819591Z","ExitCode":127,"Output":"/bin/sh: /healthcheck.sh: not found\n"},{"Start":"2023-06-30T21:49:08.582849508Z","End":"2023-06-30T21:49:08.688931134Z","ExitCode":127,"Output":"/bin/sh: /healthcheck.sh: not found\n"},{"Start":"2023-06-30T21:49:09.694490134Z","End":"2023-06-30T21:49:09.799587759Z","ExitCode":127,"Output":"/bin/sh: /healthcheck.sh: not found\n"}]}

If i should anything else please let me know. and again thanks for that quick fix and the spontaneous debugging session!

[gilbertsoft]

@rpkoller can you please check if the binaries from #5052 (comment) work for you? Thanks!

[rfay]

@rpkoller had already tested earlier version; the complexity is once the problem is solved (once the new image gets built) the problem is solved. So he can't test without going back to earlier version (with traefik enabled), deleting all build cache, deleting -built image, and then upgrading.

[rfay]

Thanks for fixing in 8f409c7 and the refactor of the embeds is 💯