New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make ddev composer create
fully compatible with composer create-project
#5058
feat: make ddev composer create
fully compatible with composer create-project
#5058
Conversation
Download the artifacts for this pull request:
See Testing a PR |
I appreciate the creativity here and look forward to looking at this more, but you should know that |
a58f6ee
to
d104f29
Compare
No hurry to get it in. Has to be tested for all project types. Thanks to @rpkoller who makes a great job in testing :) But this is a big step for |
ddev composer create
fully compatible with composer create-project
Manually tested craftcms without the --no-scripts and it worked fine. |
040f997
to
763ca2c
Compare
763ca2c
to
9d652f3
Compare
Rebased. |
Please make sure when working on this that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and I would postpone this PR, because of the changes in the docs.
People who are looking at the latest docs and using the stable DDEV won't be able to use the quickstart.
Good point. The flip side is that this will be out of sync with the quickstarts before it gets pulled, but we can survive that. I sure hope there's nothing bad about this. But we also need experience with this in the meantime, so it's a catch-22 |
Out of curiosity, cuz i haven't considered that point as a potential problem yet, are there many people using the current stable version of DDEV with the latest version of the docs on ddev.readthedocs.io? I wouldn't have expected that this is the case cuz, at least me myself tend to use the docs that come along or are on par with the version i currently use? |
@rpkoller so often people use the Often we want to update the docs for current users. Sometimes (like here) we don't want to until they have it in their hands. Most people don't know there are two versions, or know what the two versions mean. Would love to have you think about this (in a new issue if we don't have one). We've talked about it many times. |
Probably worth opening a discussion thread about this. |
20d2eb9
to
293f7e6
Compare
Co-authored-by: Ralf Koller <1665422+rpkoller@users.noreply.github.com>
293f7e6
to
3bace84
Compare
Rebased |
The Issue
Composer installer plugins and scripts may lead to error while cloning a package with
ddev composer create
. Some install instructions in the docs therefor use--no-scripts
to avoid issues. Users do not know about the special behavior ofddev composer create
and the differences tocomposer create-project
therefor adding--no-plugins
and--no-scripts
by default would avoid issues automatically.How This PR Solves The Issue
This PR adds the
--no-plugins
and--no-scripts
to thecomposer create-project
command to avoid issues by default and makes the manual usage of these options superfluous.There may be rare cases where plugins and scripts should be run, therefor the new flag
--preserve-flags
is introduced to fallback to the old behavior and not add these two options. But normally it should be fine to running scripts and plugins later withcomposer install
.The composer create command now emulates exactly the behavior of the original create-project command:
Manual Testing Instructions
Craft CMS and Laravel were using the
--no-scripts
option in the quick start guide and must be tested to still work properly.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes