Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: gh codespaces - bump docker-in-docker to v2 #5061

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

mandrasch
Copy link
Collaborator

@mandrasch mandrasch commented Jul 2, 2023

The Issue

How This PR Solves The Issue

  • bump to v2

Manual Testing Instructions

  • setup ddev in codespaces, check test project

Beware: setup_test_project.sh currently fails with

2023-07-02 09:41:48.611Z: + ddev delete -Oy tmp
2023-07-02 09:41:49.204Z: Failed to get project(s): could not find requested project 'tmp', you may need to use "ddev start" to add it to the project catalog
2023-07-02 09:41:49.297Z: postCreateCommand failed with exit code 1. Skipping any further user-provided commands.

I did full rebuilds, it failed on docker-in-docker v1 as well as v2.

Automated Testing Overview

  • no automated tests for codespaces so far iirc

Related Issue Link(s)

Release/Deployment Notes

@mandrasch mandrasch requested a review from a team as a code owner July 2, 2023 09:45
@mandrasch mandrasch changed the title gh codespaces: bump docker-in-docker to v2 test: gh codespaces - bump docker-in-docker to v2 Jul 2, 2023
Copy link
Member

@gilbertsoft gilbertsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

You can fix the mentioned issue in the script by changing line 10 to ddev delete -Oy tmp >/dev/null || true.

@rfay rfay changed the title test: gh codespaces - bump docker-in-docker to v2 build: gh codespaces - bump docker-in-docker to v2 Jul 3, 2023
@rfay
Copy link
Member

rfay commented Jul 3, 2023

We'll do a new package build for this.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. We can push this to new package even before pulling it if we want to, makes it easy to test on Codespaces that way.

@rfay rfay merged commit 56afe4b into ddev:master Jul 3, 2023
10 checks passed
@rfay
Copy link
Member

rfay commented Jul 3, 2023

@mandrasch I hope you'll take a look and see how this is working for you. All the various related PRs should be pulled, and new package has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants