Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make mkdocs-serve should work with no mkdocs installed [skip ci] #5063

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 3, 2023

The Issue

@mandrasch reported in https://discord.com/channels/664580571770388500/1124990159629320262/1124990159629320262 that he couldn't use the local make mkdocs-serve

How This PR Solves The Issue

Revert to explicit older docker version for mkdocs.

Manual Testing Instructions

Run make mkdocs-serve without mkdocs installed locally.

@rfay rfay requested a review from a team as a code owner July 3, 2023 02:58
@github-actions github-actions bot added the bugfix label Jul 3, 2023
@tyler36
Copy link
Collaborator

tyler36 commented Jul 3, 2023

Confirmed fixed.

I do not have mkdocs installed locally (WSL), so the command was falling back to docker solution.
This was failing with the following error: stderr: 'fatal: detected dubious ownership in repository at '/docs

After explicitly setting mkdocs version to 1.2.3 in Makefile, it worked:

$ make mkdocs-serve 
...
INFO     -  Documentation built in 8.22 seconds
INFO     -  [03:02:24] Watching paths for changes: 'docs/content', 'mkdocs.yml'
INFO     -  [03:02:24] Serving on http://0.0.0.0:8000/en/latest/

@rfay rfay merged commit eec951a into ddev:master Jul 3, 2023
9 checks passed
@rfay rfay deleted the 20230702_fix_docker_mkdocs branch July 3, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants