fix: avoid instrumentation of project if none is loaded, fixes #5065

[gilbertsoft]

The Issue

• Panic when instrumentation-opt-in enabled #5065

How This PR Solves The Issue

Avoids instrumentation of the project if none is available.

Manual Testing Instructions

Run ddev --version in a folder without DDEV config.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

Shouldn't we also fix the place where it uses the invalid data? pkg/ddevapp/ddevapp.go:371

ddev/pkg/ddevapp/ddevapp.go

Line 371 in 9b3b0d9

omitted := app.OmitContainersGlobal

Seems like that also should have been initialized? Or is it the app itself that doesn't exist here?

[gilbertsoft]

Shouldn't we also fix the place where it uses the invalid data? pkg/ddevapp/ddevapp.go:371

ddev/pkg/ddevapp/ddevapp.go

Line 371 in 9b3b0d9

omitted := app.OmitContainersGlobal

Seems like that also should have been initialized? Or is it the app itself that doesn't exist here?

Yes, app does not exist, that's the problem here.

[stasadev]

$ ddev version
 ITEM             VALUE                                         
 DDEV version     v1.22.0-alpha3-30-gb57c5900                   
 architecture     amd64                                         
 db               ddev/ddev-dbserver-mariadb-10.4:v1.22.0-beta1 
 ddev-ssh-agent   ddev/ddev-ssh-agent:v1.22.0-beta1             
 docker           24.0.2                                        
 docker-compose   v2.18.1                                       
 docker-platform  dev                                           
 mutagen          0.17.1                                        
 os               linux                                         
 router           traefik:v2.10                                 
 web              ddev/ddev-webserver:v1.22.0-beta1             
 
Instrumentation is opted in, but AmplitudeAPIKey is not available. This usually means you have a locally-built ddev binary or one from a PR build. It's not an error. Please report it if you're using an official release build.

Looks like it is impossible to test this build from PR.

I tried my local build instead. I placed some dummy values ​​in pkg/versionconstants/versionconstants.go and configured the Makefile.

I use OpenSnitch to inspect my internet traffic and I see api2.amplitude.com in my connections, and DDEV works if I disable the internet.

No more errors 👍

[rfay]

Thanks for getting to the bottom of this!