refactor: detect more dependency changes #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
gilbertsoft
force-pushed
the
ci/detect-more-dep-changes
branch
from
28eed20
to
252a792
Compare
gilbertsoft
changed the title
rfay
approved these changes
Jul 4, 2023
Yes, that's why I have renamed it finally to refactor. But topic is anyway the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
We like to detect dependency changes in the CI to properly label PRs changing dependencies. The required Docker Compose version is currently located in the global config and is not taken into account
How This PR Solves The Issue
This PR moves the Docker Compose version to the version constants. To avoid import cycles the functions from version constants are moved to a new package docker/images.
Changes in the version constants are now properly label with
dependencies.Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes