Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: decrease cache update interval to have more up to date caches [skip ci] #5079

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

gilbertsoft
Copy link
Member

No description provided.

@gilbertsoft gilbertsoft requested a review from a team as a code owner July 5, 2023 08:08
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will then update the cache every time it runs (if more than a minute)? Is that what you want? I thought you were trying to prevent that.

@gilbertsoft
Copy link
Member Author

This will then update the cache every time it runs (if more than a minute)? Is that what you want? I thought you were trying to prevent that.

This means every run on master will update the cache which is fine. I initially tried to avoid too many updates but maximum time for the cache transfer for the biggest cache is less than 10 seconds, so does not hurt to update the caches on every run.

@gilbertsoft
Copy link
Member Author

Changed again after our discussion about the usage of the assets. Now pull-push-test-platforms is prefered to store the cache because all assets are downloaded in theses tests.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certainly willing to try it!

@rfay rfay merged commit 25096f8 into ddev:master Jul 5, 2023
5 checks passed
@rfay rfay deleted the ci/decrease-cache-interval branch July 5, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants