Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: implement clean up and update of Homebrew cache [skip ci] #5080

Merged
merged 1 commit into from
Jul 5, 2023
Merged

ci: implement clean up and update of Homebrew cache [skip ci] #5080

merged 1 commit into from
Jul 5, 2023

Conversation

gilbertsoft
Copy link
Member

No description provided.

rfay
rfay reviewed Jul 5, 2023
View reviewed changes
.github/workflows/colima-tests.yml
uses: Homebrew/actions/setup-homebrew@master
- name: Clean up Homebrew
run: |
brew update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew update is done automatically by brew upgrade these days, but this does no harm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not find any hint on that in the docs. Only cleanup is mentioned. https://docs.brew.sh/Manpage#upgrade-options-outdated_formulaoutdated_cask-

rfay
rfay approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with doing this. It's all a learning process. Still interested in speeding things up by removing the use of homebrew.

@gilbertsoft gilbertsoft marked this pull request as ready for review July 5, 2023 17:25
@gilbertsoft gilbertsoft requested a review from a team as a code owner July 5, 2023 17:25
rfay
rfay approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fine with doing this. It is also very low risk, affects only colima, etc.

@rfay rfay merged commit 1464672 into ddev:master Jul 5, 2023
8 checks passed
@rfay rfay deleted the ci/cleanup-homebrew branch July 5, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbertsoft @rfay