fix: quote host parameter for HeidiSQL and prevent argument double quoting

[andreashager]

The Issue

When launching HeidiSQL via ddev heidisql there is an additional double quote at the end of each database connection name. If you remove the double quotes from the arguments the host parameter must be written in double quotes as the documentation suggests it (Docu: https://www.heidisql.com/help.php#commandline).

How This PR Solves The Issue

This PR removes the double quotes at the end of the string and adds them to the host parameter.

Manual Testing Instructions

Runddev heidisql to start HeidiSQL from WSL2 with correct name.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

Thanks for the contribution!

We would have reopened this for you, you didn't have to delete it, just needed the title adjusted :)

From the other PR:

Last I tested this it worked OK. What is the symptom that you encountered?

[andreashager]

OK didn't know that 🙂

The command itself worked fine but in the connection manager of HeidiSQL shows an additional double quote at the end (have a look at the screenshot). And this happens because of the quotation of $arguments than HeidiSQL adds the last double quote to the database description name.

Additionally I found at that the host parameter need to be embedded in double quotes according to documentation of HeidiSQL. So I also add them to the command 🙂

[rfay]

Seems fine to me, thanks!

[andreashager]

Cool thanks 🥳😎

[gilbertsoft]

Thanks! Works here on traditional Windows and WSL 2